window makes knocking noise as it goes up

Recently fitted new o/s front window regulator, but when you press button to close window it makes a knocking noise, can't work out what it is as I've taken regulator off and started again and it still makes the knocking noise has anybody any ideas on what it may be and how to cure it, would appreciate any information thanks

is it on a robin reliant?

The winders in my 90 are as smooth as silk. The old ways are the best LOL

does the window move, does it do it at the top/bottom of the travel.

did you lube the runners, use a silicon spray, works well, if it does it when it gets to the top, the limit switches may need setting or replacing.
if its all the time its moving, is everything aligned properly?

This is what happens when you get to the stage of evolution that means you can't be arsed to wind a window up. All progress is backwards man.